Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Datetime Concept]: Booking Up for Beauty Exercise #3567

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

colinleach
Copy link
Contributor

Incomplete draft for discussion. This is a fairly direct port from C#.

Is this suitable for the datetime concept? Usual options:

  • Use with minor tweaks.
  • Use after substantial revision.
  • Scrap it and think of something better.

Some things I'm unhappy about:

  • It's all datetime.datetime, nothing much about time or date
  • Task 2 is locale-specific. It works for me (in the US) and should be OK on the test runner, but will fail for non-English locales. The test file could set the locale to EN-US, but I'm reluctant to mess with users' machine settings unless I'm very confident of restoring it at the end of the test.
  • Task 6 is really lame.

@BethanyG BethanyG changed the title booking-up-for-beauty concept exercise [Datetime Concept]: Booking Up for Beauty Exercise Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant